FIX (Extension) @W-16733527@ Additional telemetry for apex guru #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
reviewed
Sep 27, 2024
src/apexguru/apex-guru-service.ts
Outdated
| duration: (Date.now() - startTime).toString() | ||
| duration: (Date.now() - startTime).toString(), | ||
| violationsCount: ruleResult.violations.length.toString(), | ||
| violationsWithSuggestedCode: getViolationsWithSuggestions(ruleResult).toString() |
There was a problem hiding this comment.
Should this be violationsWithSuggestedCodeCount to match violationsCount?
There was a problem hiding this comment.
Yes! that sounds better. I'll rename it.
jag-j
commented
Sep 27, 2024
| const range = this.diagnostic.range; // Assuming the range is the location of the existing code in the document | ||
| const diagnosticStartLine = new vscode.Position(range.start.line, range.start.character); | ||
| edit.insert(document.uri, diagnosticStartLine, suggestedCode + '\n'); |
There was a problem hiding this comment.
If I do this, there is no way to get the telemetry on how many times users clicked on the "include apex guru suggestions" quick-fix. I had to to make this a command and add it to the action and I can report telemetry on that command.
jag-j
commented
Sep 27, 2024
| const edit = new vscode.WorkspaceEdit(); | ||
| edit.insert(document.uri, position, suggestedCode); | ||
| await vscode.workspace.applyEdit(edit); | ||
| TelemetryService.sendCommandEvent(Constants.TELEM_SUCCESSFUL_APEX_GURU_FILE_ANALYSIS, { |
There was a problem hiding this comment.
New telemetry to get number of times users used the suggestions ApexGuru provided, along with the number of lines that were included.
…ress review comments
jfeingold35
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the following telemetry:
Number of antipatterns count
Number of violations with suggestions
Number of quick-fix accepted